fix: FileProvider.validate() leaked files outside root #4474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4474 +/- ##
=======================================
Coverage 89.03% 89.03%
=======================================
Files 722 722
Lines 33311 33316 +5
Branches 4940 4941 +1
=======================================
+ Hits 29659 29664 +5
Misses 2922 2922
Partials 730 730
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xiangce
reviewed
Jun 24, 2025
xiangce
added
the
data processing
xiangce
approved these changes
Oct 8, 2025
There was a problem hiding this comment.
Per our F2F discussion, this PR is ready to merge. @jholecek-rh - please rebase it firstly and open another PR to the 3.0_egg branch for the same change. Thanks.
xiangce
added
RPM
Fixes two issues and adds two improvements: * FileProvider would read files outside the root if the root were a prefix of the file path string-wise. Consider a root path `/tmp/sample/root` and a relative path `../root.txt`, resulting in reading a file `/tmp/sample/root.txt`. * The "inside root" check was performed after checking if file existed. This would expose information about files outside the root through the exception. While an exploit would be difficult (if possible at all), it is better to fix this weakness anyway. * The exception type is changed from the most generic `Exception` to `ValueError` to make it easier to distinguish it from `ContentException` that is raised in other cases. * The `"/"` literal in path operations is changed to `os.sep` to improve portability. Signed-off-by: Jan Holeček <71874510+jholecek-rh@users.noreply.github.com>
jholecek-rh
force-pushed
the
fix_validate_leak
branch
from
a039111 to
1bb158d
Compare
1 task
|
@xiangce Both done. The DCO check is failing on the other PR but I think it is from a previous version of the PR which I created against master by mistake. I didn't find a way to restart the check. This new process with two PRs for every change seems very labor-intensive and error-prone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Fixes two issues and adds two improvements:
FileProvider would read files outside the root if the root were a prefix of the file path string-wise. Consider a root path
/tmp/sample/rootand a relative path../root.txt, resulting in reading a file/tmp/sample/root.txt.The "inside root" check was performed after checking if file existed. This would expose information about files outside the root through the exception. While an exploit would be difficult (if possible at all), it is better to fix this weakness anyway.
The exception type is changed from the most generic
ExceptiontoValueErrorto make it easier to distinguish it fromContentExceptionthat is raised in other cases.The
"/"literal in path operations is changed toos.septo improve portability.